[XPU][TritonIntelGPUToLLVM] Add support for more shuffle kinds #2799
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for layout conversion shuffles in which rows managed by a single thread are contiguous in the output matrix. Signed-off-by: victor-eds <[email protected]>
third_party/intel/lib/TritonIntelGPUToLLVM/ConvertLayoutOpToLLVM.cpp
Outdated
Show resolved
Hide resolved
whitneywhtsang
approved these changes
Nov 22, 2024
etiotto
approved these changes
Nov 26, 2024
| // CHECK: %[[VAL_1:.*]] = llvm.extractvalue %[[VAL_0]][0] : !llvm.struct<(f16, f16)> | ||
| // CHECK: %[[VAL_2:.*]] = llvm.extractvalue %[[VAL_0]][1] : !llvm.struct<(f16, f16)> | ||
| // COM: Check the shuffles are "coalesced" | ||
| // CHECK: llvm.call spir_funccc @_Z17sub_group_shuffleDhj(%[[VAL_1]] |
Contributor
There was a problem hiding this comment.
ah would be nice if CHECK-COUNT could work with more than one line (so we could check that a pattern involving more than one line repeats a specified number of times). AFAIK this is not possible though.
| int32_t laneSize) { | ||
| std::vector<std::vector<int32_t>> bases; | ||
| std::vector<int32_t> curr(2); | ||
| int i = 1; |
Contributor
There was a problem hiding this comment.
[NIT]: int -> int32_t (consistency with surrounding code)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for layout conversion shuffles in which rows managed by a single thread are contiguous in the output matrix.
Step 2/2 to #2749